Thread Rating:
  • 2 Vote(s) - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5

[MyBB Plugin] Board Announcements Manager (For 1.6 and 1.8)

#37
I looked over both files. These look fantastic. The only thing that I saw that was missing was a string related to the custom class field:

['bam_remove_custom_class'] .= "<br /><br />Example: \"blue my_custom_class\" &nbsp;&nbsp; (separate multiple classes by spaces)<br />";
$l['bam_remove_custom_class'] .= "Built in classes: red, blue, yellow, green, magenta, orange, silver <br/><br />";

That particular string is very rarely shown, so it's completely fine as is. It's otherwise perfect.

Would you be okay if we upload the translation on the official MyBB Mod Site upload? With a credit to you, of course. Smile
Saturn-Moon.com - Our next project...
Reply
#38
Yes Yes Yesyou can publish it:

If you want, change that to

but I didn't want to translate the color names into German because of the javascript


$l['bam_remove_custom_class'] .= "<br /><br />Beispiel: \"blue my_custom_class\" &nbsp;&nbsp; (Trennen Sie mehrere Grundfarben durch Leerzeichen)<br />";

$l['bam_remove_custom_class'] .= "Die Grundfarben: red, blue, yellow, green, magenta, orange, silver <br /><br />";

 [Image: autism4all.png]
[x] <= Drive in nail here for new display!
Reply
#39
Unfortunately the colors will pretty much have to stay as far as the color names themselves. That’s a good point. We would have to translate the CSS class names themselves to do that, which would involve modifying some stuff deeper in the plugin.

I’ll publish it this weekend. Awesome work!
Saturn-Moon.com - Our next project...
Reply
#40
(March 27th, 2020 at 4:01 PM)Darth-Apple Wrote: I looked over both files. These look fantastic. The only thing that I saw that was missing was a string related to the custom class field:

['bam_remove_custom_class'] .= "<br /><br />Example: \"blue my_custom_class\" &nbsp;&nbsp; (separate multiple classes by spaces)<br />";
$l['bam_remove_custom_class'] .= "Built in classes: red, blue, yellow, green, magenta, orange, silver <br/><br />";

That particular string is very rarely shown, so it's completely fine as is. It's otherwise perfect.

Would you be okay if we upload the translation on the official MyBB Mod Site upload? With a credit to you, of course. Smile

(March 27th, 2020 at 4:37 PM)Darth-Apple Wrote: Unfortunately the colors will pretty much have to stay as far as the color names themselves. That’s a good point. We would have to translate the CSS class names themselves to do that, which would involve modifying some stuff deeper in the plugin.

I’ll publish it this weekend. Awesome work!
Thank you, thank you, gladly, what is it all about? Credit for me? what ist This ?  Confused Huh
 [Image: autism4all.png]
[x] <= Drive in nail here for new display!
Reply
#41
I’ll put a note saying “German translation by TC4ME at autism4all.at” or something similar. Smile
Saturn-Moon.com - Our next project...
Reply
#42
:-) Thanks, but that's nice
 [Image: autism4all.png]
[x] <= Drive in nail here for new display!
Reply
#43
Hello @Darth-Apple , is there still an update Bam 3 or something? If only a suggestion.

A headline / header above the announcement after that dividing line,

which is also entered via the input field in Acp. If or if the admin does not enter a heading, then it should look like the BAM 2. I just did it in the template as it might look. Would only be an idea of mine :-)


look in the test forum

greets Tc4me


Attached Files Image(s)
   
 [Image: autism4all.png]
[x] <= Drive in nail here for new display!
Reply
#44
two things: first is there any way to have the text be aligned through configuration instead of having it text-align: center

second the dismal button "x" doesn't seem to invoke anything - it doesn't dismiss - any clues?
Reply
#45
@tc4me: Looks good! I'll look into it. I will say we may opt for tags to do something of this sort, only because modifying the database fields to add multiple announcement text fields can make the upgrade process very difficult. But I'll look into something of the sort. Smile

@saucerman: I'd be interested in looking into this issue personally. Do you have a forum URL I can check? I'm not able to reproduce the issue here, but we should be able to figure out what it is and resolve!

Also, the text-align is something we've considered changing in the past. I'll add a setting in 2.1 for this.
Saturn-Moon.com - Our next project...
Reply
#46
so I found the problem with the script not invoking...there was a conflict in the  .ready(function and it was throwing a js error...to get around this I simply changed in your script include file all your "$("  to "jQuery(" and it worked like a charm.  Since many js libraries use $ as a function/variable to avoid the conflict I used jQuery.  you cannot guarantee that a function name is unique so it's best to use it's reference.
Reply
#47
(May 9th, 2020 at 12:38 AM)saucerman Wrote: so I found the problem with the script not invoking...there was a conflict in the  .ready(function and it was throwing a js error...to get around this I simply changed in your script include file all your "$("  to "jQuery(" and it worked like a charm.  Since many js libraries use $ as a function/variable to avoid the conflict I used jQuery.  you cannot guarantee that a function name is unique so it's best to use it's reference.

Thank you for testing and resolving this. I will include the fix in a future version. Smile
Saturn-Moon.com - Our next project...
Reply
#48
@Darth-Apple great thx
 [Image: autism4all.png]
[x] <= Drive in nail here for new display!
Reply


Possibly Related Threads…
Thread Author Replies Views Last Post
  [MyBB Plugin] Average Profile Ratings Darth-Apple 8 644 October 22nd, 2020 at 6:41 AM
Last Post: tc4me
  Simple Reputation Bars [MyBB Plugin] Darth-Apple 7 125 October 22nd, 2020 at 4:25 AM
Last Post: tc4me
  MyBB Post Activity Plugin Guardian 8 1,137 May 3rd, 2020 at 7:36 PM
Last Post: tc4me
  [MyBB Plugin] Latest Visitors on Profiles (for 1.8) Darth-Apple 9 13,355 November 27th, 2014 at 3:28 PM
Last Post: Harry K.



Users browsing this thread: 1 Guest(s)

Makestation Theme/Design Selector

Contact Us | Makestation | Return to Top | Lite (Archive) Mode | RSS Syndication 
Proudly powered by MyBB 1.8, © 2002-2020
Forum design by Makestation Team © 2020
Saturn-Moon.com - a modern day time capsule | Makestation Ajax Chat Hosting